Skip to content

SYCL: Fix im2col #12910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

SYCL: Fix im2col #12910

merged 3 commits into from
Apr 14, 2025

Conversation

@qnixsynapse
Copy link
Collaborator

@qnixsynapse qnixsynapse commented Apr 12, 2025 •
edited
Loading

It was necessary to fix Gemma 3 vision:

After this change, Gemma 3 vision working:
image

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Apr 12, 2025
NeoZhangJianyu
NeoZhangJianyu reviewed Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It' good work!
have you run CI locally?

@qnixsynapse
Copy link
Collaborator Author

@NeoZhangJianyu Yes. Should I trigger it here as well?

Rbiessy
Rbiessy reviewed Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NeoZhangJianyu
Copy link
Collaborator

@NeoZhangJianyu Yes. Should I trigger it here as well?

OK, I trust you!
No need the online CI.

@Rbiessy Rbiessy merged commit 75afa0a into master Apr 14, 2025
54 of 55 checks passed
@Rbiessy Rbiessy deleted the fix_im2col branch April 14, 2025 12:24
colout pushed a commit to colout/llama.cpp that referenced this pull request Apr 21, 2025
@qnixsynapse @jwcolin
SYCL: Fix im2col (ggml-org#12910)
2d9470b 
* SYCL: Fix im2col

* restore local workgroup size adjustments for large inputs

* restore format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NeoZhangJianyu NeoZhangJianyu NeoZhangJianyu left review comments

+1 more reviewer

@Rbiessy Rbiessy Rbiessy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qnixsynapse @NeoZhangJianyu @Rbiessy