SYCL: Refactor and enable FP16 in binary broadcast OPs #12975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
Rbiessy
reviewed
Apr 18, 2025
AD2605
reviewed
Apr 18, 2025
Rbiessy
approved these changes
Apr 18, 2025
colout
pushed a commit
to colout/llama.cpp
that referenced
this pull request
Apr 21, 2025
* SYCL: refactor move to a separate file * Fix binbcast * Remove duplicates * fix include formatting * fix typo
pockers21
pushed a commit
to pockers21/llama.cpp
that referenced
this pull request
Apr 28, 2025
* SYCL: refactor move to a separate file * Fix binbcast * Remove duplicates * fix include formatting * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the original dispatcher logic was incorrect. Refactored and enabled FP16 on these operations.
I have structured this branch in a way so that each commit can be inspected properly by reviewers.
test-backend-ops is passing with this change.