-
Notifications
You must be signed in to change notification settings - Fork 13.5k
make memset range dynamic #13002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
pockers21
wants to merge
54
commits into
ggml-org:master
from
pockers21:feature-dynamic-memset-range
Closed
make memset range dynamic #13002
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
b637bc6
make memset range dynamic
218d19e
rpc : add RPC_CMD_HELLO (#12955)
rgerganov 5ffc9a2
mtmd : add methods to access `mtmd_image_tokens` (#12906)
ngxson c1079ff
SYCL: Refactor and enable FP16 in binary broadcast OPs (#12975)
qnixsynapse 16f1384
server : use std::move whenever possible (#12936)
ngxson 853b98e
gguf-py : GGUF Editor GUI - Python + Qt6 (#12930)
christopherthompson81 ed7eed0
main : Fix Ctrl+D/newline handling (#12951)
danielzgtg ad6c775
clip : refactor, add `image_manipulation` and `llava_uhd` classes (#1…
ngxson 46303f5
gguf-py : fix upload python package workflow (#13020)
CISC 6eb4bb0
Disable CI cross-compile builds (#13022)
bandoti 1f3ca67
metal: add neg operator (#13029)
jmorganca bd281db
vulkan: support noncontiguous rms_norm (#13031)
jeffbolznv 104cf86
llava: fix errors in clip.h on certain compilers (#13030)
jmorganca 361eb6f
convert : experimental support for `--mmproj` flag (#13023)
ngxson 3ee8936
mtmd : merge llava, gemma3 and minicpmv CLI into single `llama-mtmd-c…
ngxson 0da1f2c
SYCL: Add non-contiguous support in ROPE (#12993)
qnixsynapse 0190b62
ggml : add SSE 4.2 and x64 base variant for CPUs without AVX (#12871)
slaren a034e66
llava : update documentations (#13055)
ngxson 949e67e
metal : add memory pool for temp allocs (#12850)
ggerganov 2d59f44
security : add note about RPC and server functionality (#13061)
ggerganov cb04870
mtmd : support SmolVLM (version 1 and 2) (#13050)
ngxson e8558fd
CUDA: noncont MMVQ + batched bs1 MUL_MAT_ID (#13014)
JohannesGaessler 7513bbe
rpc : add command line option for number of threads for the CPU backe…
rgerganov 5978039
convert : Append mult-eos,half-rope,bos to GLM4-0414 and Z (#13021)
piDack 5027efb
mtmd : Support Pixtral 12B (#13065)
ngxson 777310b
llama-mtmd-cli: Sigint rework in mtmd vision example (#13080)
pl752 58e6fbc
vulkan: matmul gcn tuning (#13016)
netrunnereve 230d0c6
metal : fix floating-point range of attention scores in FA kernels (#…
ggerganov 95aaaf1
arg : clean up handling --mmproj with -hf (#13082)
ngxson c58030f
arg : add --no-mmproj-offload (#13093)
ngxson af62651
clang-tidy : disable warning about missing math parenthesis (#13091)
ggerganov 3f08e60
cmake : do not include ./src as public for libllama (#13062)
ggerganov 6de7809
CUDA: use switch statements in constexpr functions (#13095)
JohannesGaessler dfedb1b
ggml : Depthwise 2D convolution (ggml/1152)
Acly 2e595bd
sync : ggml
ggerganov 24c0b67
ggml : fix trailing whitespaces (#0)
ggerganov 0414304
embeddings : fix batch sizes (#13076)
ggerganov 01f08e9
clip : remove boi/eoi embeddings for GLM-edge model (#13081)
ngxson 1763285
rpc : do not wait for response when sending RPC_CMD_SET_TENSOR (#12943)
rgerganov 9db1139
change the reorder tensor from init to execute OP (#13003)
NeoZhangJianyu e306c33
clip : fix pixtral on some GPU backends (#13097)
ngxson a9f6135
Force FP32 compute in GLM4 FFN Down (#13101)
city96 1f7a36f
llama : fix K-shift with quantized K and BLAS backend (#13113)
slaren dd23581
grammar : handle maxItems == 0 in JSON schema (#13117)
rick-github 4b6575c
ggml: move fp16/bf16 conversion optimizations to CPU backend + export…
SongXiaoXi cc00eb2
clip : improve projector naming (#13118)
ngxson 4f3ba1c
common : add common_remote_get_content (#13123)
ngxson 35b7fec
clip : Add Qwen2.5VL support (#12402)
HimariO d350aed
Fixes Qwen2.5VL segfault during inference with https://github.com/ggm…
LostRuins aff089e
musa: fix build warning (#13129)
yeahdongcn 201056c
llama-chat : fix wrong template in GLM4-0414 (#13140)
matteoserva b2604c3
llama-bench : Add `--override-tensors` arg (#12922)
4onen 558ab0a
arg : fix unused variable (#13142)
ngxson 1ba4571
delete set size and delete buffer clear as suggested
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will cause memory leak rather than actually saving memory
And worst, if
cur_sizeis bigger than the actually capacity of the buffer, you're now having buffer overflowUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1, I will carefully review for potential memory leaks.
2, if the buffer is unallocated or the new size exceeds the previous size, it should allocate a new buffer of the new size. With this code:
if (!buf_output || prev_size < new_size) { buf_output.reset(ggml_backend_buft_alloc_buffer(buft, new_size)); }
it shouldn't cause out-of-bounds issues, correct?