server : fix coredump on std::terminate() #12831 #13088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
reviewed
Apr 24, 2025
|
|
||
| if (!running) { | ||
| SRV_DBG("%s : queue result stop\n", __func__); | ||
| auto res = std::make_unique<server_task_result_error>(); |
There was a problem hiding this comment.
It's not a good idea to return server_task_result_error
Some handlers create task with type cancel upon receiving server_task_result_error, so the server will probably hangs. You should check all code paths, not just one single use case.
It's better to throw an exception here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to
#12831
std::terminate make coredump again
So perhaps returning "server_task_result_error" to indicate that the server has stopped,
is the most straightforward way to terminate the process with minimal changes.
original code
new code
@ngxson Please take a look at this review