PowerPC: Enable MMA for BF16 in llamafile_sgemm #13148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
shalinib-ibm
force-pushed
the
main_bf16_sgemm
branch
from
6813bbe to
b2910f5
Compare
Contributor
Author
|
@ggerganov Can you please review this PR and provide your comments ? |
ggerganov
reviewed
Apr 30, 2025
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
I don't have a machine to test this, but at least fix the indentation of the code and we can merge it.
shalinib-ibm
force-pushed
the
main_bf16_sgemm
branch
3 times, most recently
from
c6c14fa to
b9c6af2
Compare
This patch upstreams llamafile's cpu matrix multiplication kernels for ppc64le using MMA builtins for BF16 data type. This change results in 9x - 40x gains in total speed S t/s (ie all tokens/total time), across various batch sizes tested using llama-batched-bench benchmark. The patch is tested with Meta-Lllama-3-8B, and Mistral-7B models (BF16 models generated by using llama-quantize from corresponding FP32 models) on an IBM POWER10 machine. Signed-off-by: Shalini Salomi Bodapati <[email protected]>
shalinib-ibm
force-pushed
the
main_bf16_sgemm
branch
from
b9c6af2 to
203993c
Compare
Contributor
Author
Thank you @ggerganov . I have fixed the code indent. Can you please review ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch upstreams llamafile's cpu matrix multiplication kernels for ppc64le using MMA builtins for BF16 data type.
This change results in 9x - 40x gains
in total speed S t/s (ie all tokens/total time), across various batch sizes tested using llama-batched-bench benchmark.
The patch is tested with Meta-Lllama-3-8B,
and Mistral-7B models (BF16 models generated by using llama-quantize from corresponding FP32 models) on an IBM POWER10 machine.
Make sure to read the contributing guidelines before submitting a PR