mtmd-cli : fix out_of_range when input image path is empty #13244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
reviewed
May 1, 2025
examples/llava/mtmd-cli.cpp
Outdated
| g_is_generating = true; | ||
| if (line.find("/image") == 0) { | ||
| std::string image = line.substr(7); | ||
| std::string image = (line.size()>=7) ? line.substr(7) : ""; |
There was a problem hiding this comment.
hmm this logic looks a bit hacky, I will replace it with something cleaner
There was a problem hiding this comment.
Sure, please. Thanks for checking out.
CISC
requested changes
May 1, 2025
Co-authored-by: Sigbjørn Skjæret <[email protected]>
|
@CISC what I want to do is to load the image right away if possible, will push a commit for it |
|
The CLI will try to load image right away, so it can now detect if the image is not exist: |
ngxson
approved these changes
May 1, 2025
ngxson
changed the title
CISC
requested changes
May 1, 2025
Co-authored-by: Sigbjørn Skjæret <[email protected]>
CISC
approved these changes
May 1, 2025
CISC
reviewed
May 1, 2025
ngxson
reviewed
May 1, 2025
ngxson
reviewed
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking substring for the input case
"/image"results in out_of_range exception.
This PR adds a check so that doesn't happen. This maintains the continuation of the loop.