Skip to content

Conversation

@piDack
Copy link
Contributor

@piDack piDack commented May 6, 2025

Make sure to read the contributing guidelines before submitting a PR

The GLM 1.5B model uses tied embeddings, but the chatglm architecture does not take this into account, resulting in a ‘missing tensor ‘output.weight’’ error.this pr is fixed this issue.

@CISC
Copy link
Collaborator

CISC commented May 6, 2025

BTW, I checked both the safetensors and GGUFs, and even though it has tied word embeddings enabled the safetensors have both sets of (most likely identical) weights, and thus the GGUFs also.

Which GGUF file gave you this error?

To make such a GGUF you would have to do something similar to this (which could make sense to incorporate into this PR, but I'd like to know where and why such a GGUF already exists first):

# assuming token_embd.weight is seen before output.weight
if self._tok_embd is not None and new_name == output_name:
if torch.equal(self._tok_embd, data_torch):
logger.debug(f"{output_name} is equivalent to {tok_embd_name}, omitting")
return []

@piDack
Copy link
Contributor Author

piDack commented May 7, 2025

BTW, I checked both the safetensors and GGUFs, and even though it has tied word embeddings enabled the safetensors have both sets of (most likely identical) weights, and thus the GGUFs also.

Which GGUF file gave you this error?

To make such a GGUF you would have to do something similar to this (which could make sense to incorporate into this PR, but I'd like to know where and why such a GGUF already exists first):

# assuming token_embd.weight is seen before output.weight
if self._tok_embd is not None and new_name == output_name:
if torch.equal(self._tok_embd, data_torch):
logger.debug(f"{output_name} is equivalent to {tok_embd_name}, omitting")
return []

I’m sorry, this weight does not come from Hugging Face, but is for my own testing purposes. Indeed, there is no output.weight in the safetensor.
huggingface weight output

image

myself weight output
image

I think adding relevant checks is the right thing to do; at the very least, it can prevent some problems.right?

Format adjustment

Co-authored-by: Sigbjørn Skjæret <[email protected]>
@CISC CISC merged commit 6c7fd67 into ggml-org:master May 7, 2025
46 checks passed
@engineer1109
Copy link

Good Job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants