Skip to content

sampling: make top_n_sigma no-op at <=0 rather than <0 #13345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025
Merged

sampling: make top_n_sigma no-op at <=0 rather than <0 #13345

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d6877d
sampling: make nsigma == 0 a no-op
DocShotgun May 6, 2025
62e51ab
sampling: short-circuit nsigma when cur_p <= 1
DocShotgun May 6, 2025
699256a
sampling: fix top_n_sigma == 0 test to reflect new behavior
DocShotgun May 6, 2025
91644d8
sampling: additional context to top_n_sigma test change
DocShotgun May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/llama-sampling.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1750,7 +1750,7 @@ static const char * llama_sampler_top_n_sigma_name(const struct llama_sampler *
static void llama_sampler_top_n_sigma_apply(struct llama_sampler * smpl, llama_token_data_array * cur_p) {
const auto * ctx = (llama_sampler_top_n_sigma *) smpl->ctx;

if (ctx->n < 0.0f) {
if (ctx->n <= 0.0f || cur_p->size <= 1) {
return;
}

Expand Down
Loading