vulkan: enable fp16 for gcn 3 and 4 chips #13396
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically GCN 3 and 4 chips support FP16, but it's unable to process two values at once like GCN 5 can.. Since there's apparently no performance benefit
shaderFloat16is disabled in the drivers, but the chip fully supports it and RADV is able to generate those instructions.While the actual FMAs won't run any faster having FP16 means that I can use four times less shared memory for mul mat and save a little bit of memory bandwidth when reading the B matrix. As a result I get a little improvement in prompt processing on my RX 470.
PR:
Master:
I'm leaving this as a draft for now as it's a bit hacky and I'm not sure if the proprietary drivers support this. The good thing here though is that it'll let me work on and test the FP16 shaders using my old card.