Skip to content

readme : clarify the list of dependencies and their license #13591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

readme : clarify the list of dependencies and their license #13591

merged 1 commit into from
May 16, 2025

Conversation

@ngxson
Copy link
Collaborator

@ngxson ngxson commented May 16, 2025

I think adding this is a good practice to:

  • Embrace projects that we're depending on
  • Useful in case there are bug reports or vulnerability from upstream
  • Keep track of the list of licenses to be included

@ngxson ngxson requested review from ggerganov and slaren May 16, 2025 15:30
@ngxson
Copy link
Collaborator Author

ngxson commented May 16, 2025

Btw, I believe we're missing license for minja, we should add it to licenses directory, cc @ochafik

@ngxson ngxson merged commit 06c1e4a into ggml-org:master May 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

@slaren slaren slaren approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ngxson @ggerganov @slaren