Skip to content

SYCL: add gelu_erf kernel #13749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 27, 2025
Merged

SYCL: add gelu_erf kernel #13749

merged 3 commits into from
May 27, 2025

Conversation

@qnixsynapse
Copy link
Collaborator

@qnixsynapse qnixsynapse commented May 24, 2025

Make sure to read the contributing guidelines before submitting a PR

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels May 24, 2025
ngxson
ngxson approved these changes May 24, 2025
View reviewed changes
Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, seems like sycl is missing GGML_ROPE_TYPE_MROPE, do you want to give it a try? This type is used by text model, so it will speed up text generation for qwen 2.5

Ref PR where I added it on metal: #13457

@qnixsynapse
Copy link
Collaborator Author

qnixsynapse commented May 24, 2025

Btw, seems like sycl is missing GGML_ROPE_TYPE_MROPE, do you want to give it a try? This type is used by text model, so it will speed up text generation for qwen 2.5

Ref PR where I added it on metal: #13457

Sure. I implemented vision ROPE recently.

Will open a new PR for that.

AD2605
AD2605 reviewed May 26, 2025
View reviewed changes
AD2605
AD2605 reviewed May 26, 2025
View reviewed changes
Rbiessy
Rbiessy reviewed May 26, 2025
View reviewed changes
@qnixsynapse qnixsynapse merged commit f3101a8 into master May 27, 2025
48 checks passed
@qnixsynapse qnixsynapse deleted the sycl/gelu_erf branch May 27, 2025 15:23
@qnixsynapse qnixsynapse mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngxson ngxson ngxson approved these changes

+2 more reviewers

@AD2605 AD2605 AD2605 left review comments

@Rbiessy Rbiessy Rbiessy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qnixsynapse @ngxson @Rbiessy @AD2605