Skip to content

ggml: check if non-native endian model is being loaded #13943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2025
Merged

ggml: check if non-native endian model is being loaded #13943

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2fdf28
gguf: prevent non-native endian models from being loaded
taronaeo May 31, 2025
cc1def7
gguf: update error message
taronaeo May 31, 2025
25c971d
gguf: make the non-native endian check more verbose
taronaeo Jun 1, 2025
65bf062
ggml: move ggml_assert location
taronaeo Jun 1, 2025
c83208f
ggml: reword the endianness check error message
taronaeo Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ggml/src/gguf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,12 @@ struct gguf_context * gguf_init_from_file_impl(FILE * file, struct gguf_init_par
int64_t n_tensors = 0;

if (ok && gr.read(ctx->version)) {
if ((ctx->version & 0xFFFF) == 0x0000) {
GGML_LOG_ERROR("%s: failed to load model: host and model endian mismatch, please use a model compiled with the same endian as your host system\n", __func__);
gguf_free(ctx);
return nullptr;
}

if (ctx->version == 1) {
GGML_LOG_ERROR("%s: GGUFv1 is no longer supported, please use a more up-to-date version\n", __func__);
ok = false;
Expand Down
Loading