ggml : fix Arm NEON feature detection #14278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
|
Removed this code in #14281 |
|
Late to the party... I think hw.optional.AdvSIMD was replaced by hw.optional.arm.AdvSIMD in a recent OS update and that's why it stopped working. Anyway, this has now become obsolete with the multi-ISA/variant implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #13168, I noticed that
Q4_0repacking is no longer applied on my Mac (#13168 (comment)). I traced this to incorrectsysctlstring:"hw.optional.arm.AdvSIMD".This was like this ever since #9331. @eddnjjn Could you take a look and confirm this fix is correct.