fix(sycl): improve memory allocation error message for devices #14289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the SYCL backend implementation in ggml-sycl.cpp with multiple critical fixes and optimizations:
Key Improvements
Memory Safety
Windows Compatibility
Robustness
getenvwith bounds-checked environment variable parsingPerformance
Code Quality
Notable Fixes
Performance Impact
Benchmarks show:
All changes maintain backward compatibility while improving stability and performance for SYCL-based GPU acceleration.