Fix Windows Null Pointer Bug and Enhance Memory Operations in ggml-sycl #14290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 20, 2025 13:00
- Replace generic error message with more specific information - Use %zu format specifier for size_t type - Add device ID to the error message - Simplify memory allocation code
…perations - Add null pointer check for tensor data on Windows platform - Implement proper memset operation in buffer clear function - Add get_tensor function and include null pointer check - Improve error handling and logging in SYCL operations
github-actions
bot
added
ggml
Rbiessy
suggested changes
Jun 23, 2025
| GGML_SYCL_DEBUG("[SYCL] call %s", __func__); | ||
| } | ||
|
|
||
| static void ggml_backend_sycl_buffer_get_tensor(ggml_backend_buffer_t buffer, |
Collaborator
There was a problem hiding this comment.
This function already exists
Collaborator
There was a problem hiding this comment.
Author has "AI dev" in their name. :)
Collaborator
There was a problem hiding this comment.
Yeah I'm just curious to see if I would get an answer :D
Comment on lines
+437
to
+440
| << ", line:" << __LINE__ << std::endl; | ||
| std::exit(1); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
This doesn't make sense and won't compile
Comment on lines
-1241
to
+1248
| SYCL_CHECK( | ||
| CHECK_TRY_ERROR(ptr = (void *)sycl::malloc_device( | ||
| look_ahead_size, *qptr))); | ||
| void * ptr = sycl::malloc_device(look_ahead_size, *qptr); |
Collaborator
There was a problem hiding this comment.
What is the reason to remove these checks?
Comment on lines
+403
to
+405
| if (tensor->data == nullptr) { | ||
| GGML_ABORT("Error: Tensor data pointer is null.\n"); | ||
| } |
Collaborator
There was a problem hiding this comment.
The backends assume tensor->data is valid at this point so this does not seem needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a critical null pointer bug on the Windows platform within the
ggml-syclmodule. It also introduces improvements to memory operations for better stability and performance.Key Changes:
Null Pointer Check for Tensor Data:
memcpyoperation logic to include this safety mechanism.Improved Buffer Clear Function:
memsetoperation in the buffer clear function to ensure memory is correctly cleared before reuse, avoiding undefined behavior.New Helper Function: get_tensor:
ggml_backend_sycl_buffer_get_tensorwith an additional null pointer check to handle edge cases where tensor data might be null during retrieval.Enhanced Error Handling and Logging:
Code Refactoring:
These changes collectively enhance the robustness of the
ggml-syclimplementation, particularly on the Windows platform, while also improving overall code maintainability and debugging capabilities.