Skip to content

docs: fix broken url in main readme #14371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

docs: fix broken url in main readme #14371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ To learn more about model quantization, [read this documentation](tools/quantize

</details>

[^1]: [tools/perplexity/README.md](./tools/perplexity/README.md)
[^1]: [tools/perplexity/README.md](https://github.com/ggml-org/llama.cpp/tree/master/tools/perplexity/README.md)
Copy link
Collaborator

@CISC CISC Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[^1]: [tools/perplexity/README.md](https://github.com/ggml-org/llama.cpp/tree/master/tools/perplexity/README.md)
[^1]: [tools/perplexity/README.md](tools/perplexity/README.md)

I think the problem was just the relative path (see other links here).

Copy link

@justinclift justinclift Jun 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the first thing I tried, but the Preview in the GitHub editor gives that a broken link too so I didn't bother trying that approach further.

And yeah, the Preview DOESN'T break the near identical link in the header above it. Seems like a bug in the GitHub parser(s) somewhere.

Copy link
Collaborator

@CISC CISC Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funnily enough it's fine if you preview README.md.

Copy link
Collaborator

@CISC CISC Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a GitHub bug indeed, I suggest removing this footnote and linking the word perplexity directly instead, that seems to work just fine.

Copy link

@justinclift justinclift Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll get it done tomorrow when I'm back at work. 😄

[^2]: [https://huggingface.co/docs/transformers/perplexity](https://huggingface.co/docs/transformers/perplexity)

## [`llama-bench`](tools/llama-bench)
Expand Down