vendor : update vendored copy of google/minja #15011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lennart Austenfeld <[email protected]>
CISC
approved these changes
Aug 1, 2025
Signed-off-by: Lennart Austenfeld <[email protected]>
CISC
reviewed
Aug 1, 2025
Signed-off-by: Lennart Austenfeld <[email protected]>
|
Thank you very much, will merge when CI goes green! Edit: Nvm the failing |
|
I mean, I managed to mess up copy pasting two files (lesson learned: installed the editorconfig plugin) so I don't know how much you should be thanking me. Anyways, thank you for looking at this so quickly. |
Nah, no worries. :) |
BradHutchings
added a commit
to BradHutchings/Mmojo-Server
that referenced
this pull request
Aug 1, 2025
vendor : update vendored copy of google/minja (ggml-org#15011)
Nexesenex
pushed a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Aug 2, 2025
* vendor : update vendored copy of google/minja Signed-off-by: Lennart Austenfeld <[email protected]> * Re-remove trailing whitespace Signed-off-by: Lennart Austenfeld <[email protected]> * Remove another trailing whitespace Signed-off-by: Lennart Austenfeld <[email protected]> --------- Signed-off-by: Lennart Austenfeld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the vendored copy of google/minja to the latest version.
This pulls in fixes for the SmolLM3 chat template (see: google/minja#74), namely the
inoperator on strings and thestring.replacefunction.This also fixes chat templates like Deepseek R1, which use
{% if "</think>" in message["content"] %}to detect and then strip reasoning content in older assistant messages.The other changes pulled in are google/minja#72 and google/minja#75 which fix a bug with an older version of the Qwen chat template.