Skip to content

chat : Avoid partial reasoning tags in response content #15149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+15 −0
Closed

chat : Avoid partial reasoning tags in response content #15149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions common/chat-parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,13 @@ bool common_chat_msg_parser::try_consume_literal(const std::string & literal) {
auto pos = pos_;
for (auto i = 0u; i < literal.size(); ++i) {
if (pos >= input_.size()) {
if (is_partial() && i > 0) {
// For partial message, whose suffix matches the literal, report
// that it can be consumed. We need more content to be able to
// tell otherwise.
pos_ = pos;
return true;
}
return false;
}
if (input_[pos] != literal[i]) {
Expand Down
8 changes: 8 additions & 0 deletions tests/test-chat-parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,14 @@ static void test_regex() {
common_chat_msg_parser builder("Hello,", is_partial, {});
assert_equals(false, builder.try_consume_literal("Oh"));
}
{
common_chat_msg_parser builder("<some>", false, {});
assert_equals(false, builder.try_consume_literal("<some><suffix>"));
}
{
common_chat_msg_parser builder("<some>", true, {});
assert_equals(true, builder.try_consume_literal("<some><suffix>"));
}
}

const std::vector<std::string> barely_healable_jsons = {
Expand Down
Loading