kleidiai: fix unsigned overflow bug #15150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
edwardtu-ampere
approved these changes
Aug 7, 2025
edwardtu-ampere
left a comment
edwardtu-ampere
left a comment
There was a problem hiding this comment.
Verified on Ampere AltraMax, no crash issue again.
Collaborator
Author
|
@ggerganov this PR has been approved by both reviewers and fixes the crash reported by Edward, who has confirmed that the patch resolves the issue on his side. I’m happy to go ahead and merge it myself 🙂 — just wanted to check in first and see if you’d prefer to handle the merge or if there’s anything else needed. |
ggerganov
approved these changes
Aug 11, 2025
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
Go ahead and merge it - thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the overflow issue reported by Edward #15079.