server: implement GLM-style MTP #15225
Draft
+211
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a draft/proof of concept I'm playing with, just one idea for an MTP implementation. Planning to test on GLM-4.5 because it's the only model out there that we've preserved NextN tensors for.
From what I can tell
So implementation-wise it seems like
mtp_speculative_gen_draft
in speculative.cpp that is vastly simplified and branch into it in server.cpp when a slot has MTP (versuscommon_speculative_gen_draft
).ctx_dft
in this case as well. It's a bit hacky but I was thinking we could just havectx_dft = ctx
and then have both normal and MTP passes write over the sharedctx
logits. I think this minimizes required code changes elsewhereThis is my first time (1) working with ML stuff outside of python (2) attempting to contribute, so patience is appreciated :)