Skip to content

vulkan: perf_logger improvements #15246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

vulkan: perf_logger improvements #15246

wants to merge 2 commits into from
+15 −9

Conversation

jeffbolznv
Copy link
Collaborator

  • Account for batch dimension in flops calculation.
  • Fix how "_VEC" is detected for mat_mul_id.
  • Fix "n" dimension for mat_mul_id (in case of broadcasting).
  • Include a->type in name.

@jeffbolznv
vulkan: perf_logger improvements
8203d3b 
- Account for batch dimension in flops calculation.
- Fix how "_VEC" is detected for mat_mul_id.
- Fix "n" dimension for mat_mul_id (in case of broadcasting).
- Include a->type in name.
@jeffbolznv jeffbolznv requested a review from 0cc4m as a code owner August 11, 2025 16:10
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Aug 11, 2025
0cc4m
0cc4m approved these changes Aug 12, 2025
View reviewed changes
ggml/src/ggml-vulkan/ggml-vulkan.cpp
const uint64_t batch = node->src[1]->ne[2] * node->src[1]->ne[3];
std::string name = ggml_op_name(node->op);
if ((node->op == GGML_OP_MUL_MAT && n == 1) ||
(node->op == GGML_OP_MUL_MAT_ID && node->src[2]->ne[1] == 1)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally the MUL_MAT / MUL_MAT_VEC difference came from the shader path it used, so maybe it makes sense to use mul_mat_vec_max_cols here instead of 1.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good idea. I'll change it in the morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0cc4m 0cc4m 0cc4m approved these changes

@zunigasllc zunigasllc zunigasllc approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffbolznv @0cc4m @zunigasllc