vulkan: perf_logger improvements #15246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jeffbolznv
commented
Aug 11, 2025
jeffbolznv
commented
- Account for batch dimension in flops calculation.
- Fix how "_VEC" is detected for mat_mul_id.
- Fix "n" dimension for mat_mul_id (in case of broadcasting).
- Include a->type in name.
- Account for batch dimension in flops calculation. - Fix how "_VEC" is detected for mat_mul_id. - Fix "n" dimension for mat_mul_id (in case of broadcasting). - Include a->type in name.
github-actions
bot
added
Vulkan
0cc4m
approved these changes
Aug 12, 2025
| const uint64_t batch = node->src[1]->ne[2] * node->src[1]->ne[3]; | ||
| std::string name = ggml_op_name(node->op); | ||
| if ((node->op == GGML_OP_MUL_MAT && n == 1) || | ||
| (node->op == GGML_OP_MUL_MAT_ID && node->src[2]->ne[1] == 1)) { |
Collaborator
There was a problem hiding this comment.
Originally the MUL_MAT / MUL_MAT_VEC difference came from the shader path it used, so maybe it makes sense to use mul_mat_vec_max_cols here instead of 1.
Collaborator
Author
There was a problem hiding this comment.
Yeah, good idea. I'll change it in the morning.
zunigasllc
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.