-
Notifications
You must be signed in to change notification settings - Fork 13.7k
vulkan.Dockerfile: install vulkan SDK using tarball #15282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Xiaodong Ye <[email protected]>
|
Hi @ngxson, could you please review this when you have a moment? Thanks. |
0cc4m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Signed-off-by: Xiaodong Ye <[email protected]>
|
Did you test this on aarch64 @0cc4m @yeahdongcn also? Something weird seems to happens, it appears like you pull the aarch64 one but when it's extracted there's only a x86_64 tarball in there: |
|
@ericcurtin Apparently there isn't an ARM SDK available for Linux, see https://vulkan.lunarg.com/issue/view/654594145df11238996e13fe |
|
We did that in the past, but it means people mostly use outdated versions of the packages, which leads to reduced performance due to unsupported features. |
|
Would moving to Ubuntu 25.04 just for the Vulkan image help? That way we keep aarch64 support |
|
Maybe it's possible to do that conditionally, based on the CPU arch? |
|
What features is x86_64 Ubuntu 25.04 Vulkan missing? Could just ping the maintainer of that package also |
|
This is what I use to build a cross-platform Vulkan SDK container image: https://gist.github.com/yeahdongcn/f57a37bfadcb0a607a6b0e5e710cbef2 |
Make sure to read the contributing guidelines before submitting a PR
I noticed the following deprecation notice on https://packages.lunarg.com/
This PR updates
vulkan.Dockerfileto install the Vulkan SDK from the tarball.Testing Done