Allow passing GGUF splits via repeated --model args #15318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case a segmented GGUF file does not follow the specified naming convention, it will not be possible to load it. So, modify the argument parser to allow repeated --model args to be specified on the CLI, and in such case assume those are GGUF splits given in order. Signed-off-by: Piotr Stankiewicz <[email protected]>
Collaborator
|
TBH this feels like an anti-feature, in which scenario would the files be incorrectly named, and why can't they just be renamed? |
Collaborator
|
Same thought with @CISC , I think we should not risk polluting the code base with a feature that less than 1% of users use. If you cannot rename the file, you can also symlink it to make correct the file name. The API for loading shards with custom naming was for downstream apps that use llama.cpp as a lib, they can manage files by naming them as SHA256 string for example. It is NOT intended to use by llama.cpp CLI |
Contributor
Author
Fair enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a segmented GGUF file does not follow the specified naming convention, it will not be possible to load it. So, modify the argument parser to allow repeated --model args to be specified on the CLI, and in such case assume those are GGUF splits given in order.