CANN: fix ggml_cann_rms_norm #15331
Closed
CANN: fix ggml_cann_rms_norm #15331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
Collaborator
|
@yuchuan-cao Thanks for your contribution! |
Collaborator
|
@yuchuan-cao Do you mind rebasing to the latest code to avoid CI failure? |
yuchuan-cao
force-pushed
the
fix_cann_rms_norm
branch
from
21967ad to
b0e95db
Compare
yuchuan-cao
force-pushed
the
fix_cann_rms_norm
branch
from
b0e95db to
37dee3d
Compare
Contributor
Author
Thanks for the reminder! I’ve rebased my code to the latest master. |
hipudding
reviewed
Aug 20, 2025
| aclTensor* acl_rstd = | ||
| aclnn_zero(ctx, zero_tensor_allocator.get(), zero_tensor_n_bytes, | ||
| src->ne, GGML_MAX_DIMS, ggml_cann_type_mapping(src->type), | ||
| rstd_ne, 3, ggml_cann_type_mapping(src->type), |
Collaborator
There was a problem hiding this comment.
I think you can just change GGML_MAX_DIMS to GGML_MAX_DIMS-1, and rstd_ne is not needed. aclnn_zero will only use acl_rstd as a 3-dim tensor.
Contributor
Author
There was a problem hiding this comment.
Indeed, thanks! I suppose #15419 would better fix this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15330
fix the alloc size of acl_rstd
the parameter
dimsis set to 3 according to CANN document