-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Fix broken build: require updated pip to support --break-system-packages #15357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line continuation backslash is missing at the end of line 63, which will cause the Docker build to fail. Add a backslash () at the end of the line to properly continue the RUN command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be enough to upgrade only the
pippackage?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slaren, @danchev, @ngxson
Since the Github Actions for publishing the dockerimage specify the "ubuntu-22.04" base image, I think it's a good idea to remove the "--break-system-packages" option from ".devops/cuda.Dockerfile."
Alternatively, instead of removing the "--break-system-packages" option, I think the base image should be based on "ubuntu-24.04."
More details below.
The "--break-system-packages" option was added on "Aug 15, 2025, 12:45 AM GMT+9" via the following issue and pull request.
Issue: Compile bug: .devops/cuda.Dockerfile fails if BASE_CUDA_DEV_CONTAINER is based on Ubuntu 24.04 #15004
PullRequest: fix compile bug when the BASE_CUDA_DEV_CONTAINER is based on Ubuntu 2… #15005
At this time, "Ubuntu The "--break-system-packages" option was added because container builds failed when using a base image with "ubuntu-24.04" specified, but the .github/workflows/docker.yml settings specifies a fixed value of "ubuntu-22.04", and the pip installed by python3-pip on ubuntu-22.04 is v22.x.
The "--break-system-packages" option is available in pip v23.1 and later, and installing pip v23.1 or later on "ubuntu-22.04" would likely be a bit of a hassle, and the impact would be significant if the base image were based on "ubuntu-24.04", so for the time being it is probably best to remove the "--break-system-packages" option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snmagn @slaren @ngxson
I apologize for the confusion. To be clear, the Docker build is currently failing not because of the addition of the
--break-system-packagesflag, but because the same PR/commit that introduced the flag also removed the line:&& pip install --upgrade pip setuptools wheel \from.devops/cuda.Dockerfile.This PR contains two commits:
--break-system-packagesflag, which was the intended change in the original PR fix compile bug when the BASE_CUDA_DEV_CONTAINER is based on Ubuntu 2… #15005.Effectively, this PR does not introduce anything new to
cuda.Dockerfile; it simply restores a line that was mistakenly removed while still keeping the intended flag addition.