-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add Trigger at PR creation #15386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Trigger at PR creation #15386
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c24dc3a
Changed the CI file to hw
alitariq4589 c465ebe
Changed the CI file to hw
alitariq4589 b599746
Added to sudoers for apt
alitariq4589 9342a37
Removed the clone command and used checkout
alitariq4589 bb19818
Added libcurl
alitariq4589 b402426
Added gcc-14
alitariq4589 e608c00
Checking gcc --version
alitariq4589 5857204
added gcc-14 symlink
alitariq4589 48fc7c5
added CC and C++ variables
alitariq4589 d8c9241
Added the gguf weight
alitariq4589 fd500f7
Changed the weights path
alitariq4589 95f4d8e
Added system specification
alitariq4589 fc453a0
Removed white spaces
alitariq4589 96d1aa6
Merge branch 'master' into alitariq4589/rvv_ci
akifejaz c1d61aa
ci: Replace Jenkins riscv native build Cloud-V pipeline with GitHub A…
akifejaz d70b2cd
Merge pull request #2 from alitariq4589/ae/rvv-native-build
akifejaz 4d21e10
removed trailing whitespaces
akifejaz 1cc9920
Added the trigger at PR creation
alitariq4589 c9bb340
Corrected OS name
alitariq4589 767c0ad
Merge branch 'master' into alitariq4589/rvv_ci
alitariq4589 304cee2
Added ccache as setup package
alitariq4589 e58e012
Added ccache for self-hosted runner
alitariq4589 0b48b25
Added directory for ccache size storage
alitariq4589 63944da
Changed the build command and added ccache debug log
alitariq4589 6d2b6fa
Added the base dir for the ccache
alitariq4589 c27aacf
Re-trigger CI
alitariq4589 71372a6
Cleanup and refactored ccache steps
alitariq4589 7344565
Cleanup and refactored ccache steps
alitariq4589 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Since we are building directly on a RISC-V Linux machine, are we still required to use a cross-compilation toolchain?
It seems that native compilation should be sufficient in this case. Could you help clarify the motivation for using a cross toolchain here? Thnaks you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the cross-compilation was only introduced because we didnt have the hardware for checking the RVV1.0 support on RISC-V. But I did not add this CI, so author may better tell us about the motivation.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @ixgbe is referring to the
gcc-14-riscv64-linux-gnu
package (which comes from your #14439 PR), which usually installs a cross-compiler, butbuild_essential
should already give you a native riscv64 compiler.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing gcc-14-riscv64-linux-gnu doesn't install a cross compiler. In fact, this is the native toolchain when the command is executed inside the riscv compute.
Also, the build essential installs 13.2.0 GCC by default, which has a vector intrinsics issue with RISC-V.
Check this issue and comment: #12693 (comment)