[WIP] server: fix web UI access of final chunk with empty choices array #15464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeoZosa
force-pushed
the
server/fix/chat-completion-chunk-empty-choices-access-in-web-ui
branch
from
5081a85 to
8753070
Compare
TeoZosa
commented
Aug 21, 2025
| throw new Error(chunk.error?.message || 'Unknown error'); | ||
| } | ||
| const addedContent = chunk.choices[0].delta.content; | ||
| const addedContent = chunk.choices?.[0].delta.content; |
There was a problem hiding this comment.
The only PR change. Returning undefined if choices is an empty array (aligning to the behavior of returning undefined if delta doesn't have a content field).
TeoZosa
changed the title
|
Closed in favor of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
(unintentionally) Duplicates #15462. Will close once that is merged.
Fixes Web UI compatibility after #15444.
Thanks to @h9j6k for catching this:
Closes:
TODO: rebuild the WebUI static files (I don't have reliable network at the moment; will get to this once that's resolved)