test-opt: allow slight inprecision #15503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CISC
approved these changes
Aug 22, 2025
| helper_after_test_forward_backward(optim, __func__, high_level, shuffle, "weights_after_forward", subtest_ok, ntest, npass); | ||
| } | ||
| { | ||
| constexpr double atol = 1e-10; |
There was a problem hiding this comment.
This variable name is slightly disturbing, can you find a better name? :)
netrunnereve
approved these changes
Aug 22, 2025
qnixsynapse
pushed a commit
to menloresearch/llama.cpp
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15491.
I implemented the CPU and CUDA code in such a way that the results for the tests would be exact and unaffected by floating point rounding error. However, I have no control over what is being implemented e.g. in Vulkan. So this PR changes the tests to allow for slight inprecision.