Skip to content

vulkan: workaround MoltenVK compile failure in multi_add #15506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2025
Merged

vulkan: workaround MoltenVK compile failure in multi_add #15506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c359d46
vulkan: workaround MoltenVK compile failure in multi_add
jeffbolznv Aug 22, 2025
6f64e1d
Update ggml/src/ggml-vulkan/vulkan-shaders/multi_add.comp
jeffbolznv Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ggml/src/ggml-vulkan/vulkan-shaders/multi_add.comp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@ layout (push_constant) uniform parameter2
uint nb[8][4];
} p;

layout (binding = 0) readonly buffer A {A_TYPE data_a[];} a[];
layout (binding = 0) writeonly buffer D {D_TYPE data_d[];} d[];
// Workaround for MoltenVK Bug, see https://github.com/ggml-org/llama.cpp/issues/15498
// layout (binding = 0) readonly buffer A {A_TYPE data_a[];} a[];
// layout (binding = 0) writeonly buffer D {D_TYPE data_d[];} d[];
layout (binding = 0) buffer A {A_TYPE data_a[];} a[];
layout (binding = 0) buffer D {D_TYPE data_d[];} d[];

layout(constant_id = 0) const uint num_srcs = 2;

Expand Down
Loading