fix(trim): prevent assertion failure in trim function #15520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with MSVC in the Debug configuration, during the execution of the
llama_chat_apply_template
function, thetrim
function (located in src/llama-chat.cpp) is called for certain models (e.g., Gemma 3). If non-ASCII characters are present in theconst struct llama_chat_message * chat
passed to thellama_chat_apply_template
function, the assertion within theisspace
function in thetrim
function will trigger an Assertion Failed error. The error message displays the expression: c >= -1 && c <= 255.To resolve this problem, I added
static_cast<unsigned char>
to theisspace
call, ensuring that negative-valued non-ASCII characters are converted to positive values.