ggml WebGPU: remove userdata from request adapter callback #15527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `userdata` parameter from the WebGPU request adapter callback in `ggml-webgpu.cpp`. Instead, the lambda function captures the `webgpu_context` directly. The motivation for this change is to simplify the code and improve readability.
github-actions
bot
added
the
ggml
I was just thinking that since the implementation is using webgpu/webgpu_cpp.h it might be a nice change in favor of somewhat simpler/more readable code (at least in my opinion). |
|
Hmm ok I didn't notice that webgpu_cpp supports both version of callback (w/ and w/o Probably it's also cleaner to move the callback to the same line with function call, like in this example: https://eliemichel.github.io/LearnWebGPU/getting-started/cpp-idioms.html#capturing-closures |
This commit removes the callback lambda variable and inlines it directly into the RequestAdapter call.
ngxson
approved these changes
Sep 5, 2025
Nothing from my end 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
userdataparameter from the WebGPU request adapter callback inggml-webgpu.cpp. Instead, the lambda function captures thewebgpu_contextdirectly.The motivation for this change is to simplify the code and improve readability.