CUDA: fix half2 -> half conversion for HIP #15529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Nvidia GPU
IMbackK
approved these changes
Aug 23, 2025
Collaborator
IMbackK
left a comment
IMbackK
left a comment
There was a problem hiding this comment.
sure yeah, true.
I cant reproduce the users issue at all, neither on ci, nor on my local machine, nor on various amd provided docker images.
FlorianZimmer
pushed a commit
to FlorianZimmer/llama.cpp
that referenced
this pull request
Aug 25, 2025
qnixsynapse
pushed a commit
to janhq/llama.cpp
that referenced
this pull request
Aug 25, 2025
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Oct 6, 2025
This reverts commit 710dfc4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15196 . Even if it doesn't fix the compilation,
__low2halfshould be used consistently to eliminate the risk of an unexpected type conversion.