Skip to content

Conversation

CISC
Copy link
Collaborator

@CISC CISC commented Aug 25, 2025

src0 data is unused in IM2COL

@CISC CISC requested a review from ggerganov August 25, 2025 21:47
@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning Apple Metal https://en.wikipedia.org/wiki/Metal_(API) labels Aug 25, 2025
@ggerganov ggerganov merged commit 0fd90db into master Aug 26, 2025
47 of 48 checks passed
@ggerganov ggerganov deleted the cisc/remove-im2col-metal-src0-assert branch August 26, 2025 06:51
Minh141120 pushed a commit to menloresearch/llama.cpp that referenced this pull request Aug 27, 2025
* remove contiguous assertion for src0 in IM2COL

* add contiguous check in supports_op
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apple Metal https://en.wikipedia.org/wiki/Metal_(API) ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eval bug: Llama-server crashes with Mistrall-Small when I pass it an image for processing.

2 participants