-
Notifications
You must be signed in to change notification settings - Fork 13.9k
fix(ggml-sycl): add synchronization before exiting argsort kernel #15582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add `stream->wait()` to ensure all kernels finish execution before proceeding - This resolves potential race conditions in the argsort operation
|
@MengAiDev The closing brace for the function is missing so it fails to compile when I tried to check out the branch. I added an extra line to close it with |
|
#15580 support on iGPU. It could reduce the protentional risk to dGPU. |
|
@NeoZhangJianyu I have an Intel Arc A770 16GB and can confirm the issue existed on my dGPU too. This is a snippet from the backtrace I posted in the issue. |
OK! Thank you for your feedback! |
|
I have fix the |
|
@MengAiDev I will continue to support SYCL backend. I test this PR, it's passed. I have created a PR to fix argsort OP too: #16521. If the merged PR (#16521) could resolved the issue, I suggest not merging this PR. How do you think? Thank you! |
stream->wait()to ensure all kernels finish execution before proceedingFixes: #15580