Skip to content

vulkan : remove unused portability_enumeration_ext variable #15679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2025
Merged

vulkan : remove unused portability_enumeration_ext variable #15679

merged 1 commit into from
Aug 31, 2025

Conversation

@danbev
Copy link
Member

@danbev danbev commented Aug 30, 2025

This commit removes the portability_enumeration_ext variable from the ggml_vk_instance_portability_enumeration_ext_available function as it is initialized to false but never modified, making it redundant.

@danbev
vulkan : remove unused portability_enumeration_ext variable
c2ff04e 
This commit removes the portability_enumeration_ext variable from the
ggml_vk_instance_portability_enumeration_ext_available function as it
is initialized to false but never modified, making it redundant.
@danbev danbev requested a review from 0cc4m as a code owner August 30, 2025 04:42
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Aug 30, 2025
0cc4m
0cc4m approved these changes Aug 31, 2025
View reviewed changes
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I must have been half-asleep when writing this.

@0cc4m 0cc4m merged commit 5c16b9c into ggml-org:master Aug 31, 2025
88 of 89 checks passed
@danbev danbev deleted the vulkan-portability-extension-var branch September 1, 2025 13:42
walidbr pushed a commit to walidbr/llama.cpp that referenced this pull request Sep 7, 2025
@danbev @walidbr
vulkan : remove unused portability_enumeration_ext variable (ggml-org…
6164f2a 
…#15679)

This commit removes the portability_enumeration_ext variable from the
ggml_vk_instance_portability_enumeration_ext_available function as it
is initialized to false but never modified, making it redundant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0cc4m 0cc4m 0cc4m approved these changes

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danbev @0cc4m