docker : Fix AMDGPU_TARGETS deprecated warnning message #15786
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiyuewa
force-pushed
the
fix-rocm-docker-build-deprecated-warnning
branch
from
e5a4143 to
cb08d6d
Compare
github-actions
bot
added
the
devops
Since ROCm 6.4 [1], AMDGPU_TARGETS has been deprecated, and will print the
warnning message if the new GPU_TARGETS is not defined:
#9 1.624 -- Detecting HIP compile features
#9 1.625 -- Detecting HIP compile features - done
#9 1.634 CMake Warning (dev) at /opt/rocm/lib/cmake/hip/hip-config-amd.cmake:70 (message):
#9 1.634 AMDGPU_TARGETS is deprecated. Please use GPU_TARGETS instead.
#9 1.634 Call Stack (most recent call first):
#9 1.634 /opt/rocm/lib/cmake/hip/hip-config.cmake:149 (include)
#9 1.634 ggml/src/ggml-hip/CMakeLists.txt:39 (find_package)
#9 1.634 This warning is for project developers. Use -Wno-dev to suppress it.
#9 1.634
#9 1.664 -- HIP and hipBLAS found
#9 1.666 -- Including HIP backend
Define both AMDGPU_TARGETS and GPU_TARGETS to make the old ROCm happy.
[1] ROCm/clr@def369a
haiyuewa
force-pushed
the
fix-rocm-docker-build-deprecated-warnning
branch
from
cb08d6d to
17867c2
Compare
|
A nit PR, close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ROCm 6.4 [1], AMDGPU_TARGETS has been deprecated, and will print the warnning message if the new GPU_TARGETS is not defined:
Define both AMDGPU_TARGETS and GPU_TARGETS to make the old ROCm happy.
[1] ROCm/clr@def369a
Make sure to read the contributing guidelines before submitting a PR