Skip to content

cuda : fix supports_op condition for get_rows when number of blocks is too large #15868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2025
Merged

cuda : fix supports_op condition for get_rows when number of blocks is too large #15868

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c1c270
cuda : fix supports_op condition for get_rows when src1->ne2 > 1
ggerganov Sep 8, 2025
c453e5e
ggml : add comment about ggml_get_rows
ggerganov Sep 8, 2025
8c2a5fa
cuda : add FIXME [no ci]
ggerganov Sep 8, 2025
2aee620
cuda : update support condition
ggerganov Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ggml/src/ggml-cuda/ggml-cuda.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3392,6 +3392,9 @@ static bool ggml_backend_cuda_device_supports_op(ggml_backend_dev_t dev, const g
return op->type == GGML_TYPE_F32 && op->src[0]->type == GGML_TYPE_F32 && op->src[1]->type == GGML_TYPE_F32;
case GGML_OP_GET_ROWS:
{
if (op->src[1]->ne[2] > 1) {
return false;
}
switch (op->src[0]->type) {
case GGML_TYPE_F16:
case GGML_TYPE_F32:
Expand Down
Loading