Skip to content

vulkan: automatically remove unsupported devices #15976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0cc4m merged 4 commits into from
Sep 17, 2025
Merged

vulkan: automatically remove unsupported devices #15976

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a7549f
remove unsupported vulkan devices
netrunnereve Sep 14, 2025
11c74f5
make this happen during selection instead
netrunnereve Sep 14, 2025
4dc1158
Merge https://github.com/ggerganov/llama.cpp into vulkan_unsupported
netrunnereve Sep 14, 2025
8b60f7a
pass by reference
netrunnereve Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ggml/src/ggml-vulkan/ggml-vulkan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4621,6 +4621,29 @@ static void ggml_vk_instance_init() {
}
}

// Remove any unsupported devices
size_t num_unsupported = 0;
for (size_t i = 0; i < vk_instance.device_indices.size();) {
vk::PhysicalDevice vkdev = devices[vk_instance.device_indices[i]];

VkPhysicalDeviceFeatures2 device_features2;
device_features2.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;

VkPhysicalDeviceVulkan11Features vk11_features;
vk11_features.pNext = nullptr;
vk11_features.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_1_FEATURES;
device_features2.pNext = &vk11_features;

vkGetPhysicalDeviceFeatures2(vkdev, &device_features2);
if (!vk11_features.storageBuffer16BitAccess) {
vk_instance.device_indices.erase(vk_instance.device_indices.begin() + i);
num_unsupported++;
} else
i++;
}
if (num_unsupported > 0)
GGML_LOG_DEBUG("ggml_vulkan: Removed %zu unsupported Vulkan devices.\n", vk_instance.device_indices.size());

if (vk_instance.device_indices.empty()) {
GGML_LOG_INFO("ggml_vulkan: No devices found.\n");
return;
Expand Down
Loading