-
Notifications
You must be signed in to change notification settings - Fork 13.4k
SYCL: Add GGML_OP_MEAN operator support #16009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e33b715
to
8393ddc
Compare
Status update: RISCV job failed due to missing runner: The job was not acquired by Runner of type self-hosted even after multiple attempts This appears unrelated to the code changes. @ggerganov @ggerganov/ggml-maintainers – |
I checked the macOS-arm64 logs – the only failing test is |
Gentle ping @NeoZhangJianyu – just checking if you had a chance to review. |
Hi @ggerganov @NeoZhangJianyu 👋 Please let me know if there’s anything I can adjust or clarify to help move it forward. |
Hi @sigbjørnSkjæret Could you please take a look or point me to the right maintainer to approve it? |
Looks like this is a serious email, but email-search generated through
ArtInt.
It is not me.
I utilise only bourneshell through vimrc forwarded to the
***@***.*** The guy You are searching maybe lives just outside
Oslo. Take a look at the attached photo:
ons. 15. okt. 2025, 12:03 skrev yael-works ***@***.***>:
… *yael-works* left a comment (ggml-org/llama.cpp#16009)
<#16009 (comment)>
Hi @sigbj <https://github.com/sigbj>ørnSkjæret
I noticed you recently commented on related PRs. My PR #16009
<#16009> adds GGML_OP_MEAN
support for SYCL and has been passing all CI checks for a month.
Could you please take a look or point me to the right maintainer to
approve it?
I’d be happy to make any adjustments if needed.
Thanks so much for your help!
—
Reply to this email directly, view it on GitHub
<#16009 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVBTEZZ3QVEISNSXUYBBWOT3XYLX7AVCNFSM6AAAAACGRMCADGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBVGU4TQMRSHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@qnixsynapse Can you review/test this, looks like @NeoZhangJianyu is busy? |
@CISC I no longer maintain SYCL and moved away from using Intel GPU. However, the code looks okay to me. |
Co-authored-by: Sigbjørn Skjæret <[email protected]>
@ggerganov Looks like we no longer have any maintainers for the SYCL backend, unless @NeoZhangJianyu reappears... |
Hi @ggerganov All CI checks are green (some still queued), and both @CISC and @qnixsynapse have reviewed the changes. Could you please take a look and approve or merge when convenient? Thanks a lot for your time and great work maintaining the project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good work!
Thank you!
This PR introduces support for GGML_OP_MEAN in the SYCL backend.
Changes:
Verification: