Skip to content

Conversation

yael-works
Copy link
Contributor

@yael-works yael-works commented Sep 15, 2025

This PR introduces support for GGML_OP_MEAN in the SYCL backend.

Changes:

  • Added ggml_sycl_op_mean() kernel and ggml_sycl_mean() wrapper
  • Registered GGML_OP_MEAN in ggml_sycl_compute_forward()
  • Updated ggml_backend_sycl_device_supports_op() to report support
  • Added proper row-wise mean implementation with parallel division

Verification:

  • Build passes successfully with CMake + make
  • ./build/bin/test-backend-ops support -o MEAN -b sycl shows
  • ./build/bin/test-backend-ops test -o MEAN -b sycl passes with OK

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Sep 15, 2025
@yael-works
Copy link
Contributor Author

Status update:
All major builds (Linux, Windows, SYCL, CUDA, macOS-x64) passed successfully.

RISCV job failed due to missing runner:

The job was not acquired by Runner of type self-hosted even after multiple attempts
Internal server error. Correlation ID: e44cad51-7cf6-459f-9d19-6597095ade25

This appears unrelated to the code changes.

@ggerganov @ggerganov/ggml-maintainers –
Please review when convenient. This PR is ready for review & merge.

@yael-works
Copy link
Contributor Author

I checked the macOS-arm64 logs – the only failing test is test-barrier (timeout).
This seems unrelated to the SYCL/MEAN implementation.
All other tests (Linux, Windows, SYCL, CUDA, etc.) pass successfully.
Happy to address anything if you think changes are needed.

@yael-works
Copy link
Contributor Author

Gentle ping @NeoZhangJianyu – just checking if you had a chance to review.
Happy to adjust anything if needed. Thanks!

@yael-works
Copy link
Contributor Author

Hi @ggerganov @NeoZhangJianyu 👋
Just following up on this PR (#16009) — it’s been a month since submission.
All CI checks are still green, and the change is limited to adding GGML_OP_MEAN support for SYCL.

Please let me know if there’s anything I can adjust or clarify to help move it forward.
Thanks again for your time and great work maintaining this project!

@yael-works
Copy link
Contributor Author

Hi @sigbjørnSkjæret
I noticed you recently commented on related PRs. My PR #16009 adds GGML_OP_MEAN support for SYCL and has been passing all CI checks for a month.

Could you please take a look or point me to the right maintainer to approve it?
I’d be happy to make any adjustments if needed.
Thanks so much for your help!

@sigbj
Copy link

sigbj commented Oct 15, 2025 via email

@yael-works
Copy link
Contributor Author

Hi @CISC

Just wanted to follow up on PR #16009. All CI checks are green and the change is limited to adding GGML_OP_MEAN support for SYCL.

Would you be able to review when convenient? Happy to make any adjustments if needed. Thanks so much for your time!

@CISC
Copy link
Collaborator

CISC commented Oct 15, 2025

@qnixsynapse Can you review/test this, looks like @NeoZhangJianyu is busy?

@qnixsynapse
Copy link
Collaborator

qnixsynapse commented Oct 15, 2025

@CISC I no longer maintain SYCL and moved away from using Intel GPU. However, the code looks okay to me.

@github-actions github-actions bot added documentation Improvements or additions to documentation build Compilation issues labels Oct 15, 2025
@CISC CISC removed testing Everything test related Nvidia GPU Issues specific to Nvidia GPUs nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment Vulkan Issues specific to the Vulkan backend examples python python script changes devops improvements to build systems and github actions server Apple Metal https://en.wikipedia.org/wiki/Metal_(API) Ascend NPU issues specific to Ascend NPUs OpenCL Issues specific to the OpenCL backend IBM zDNN issues specific to IBM zDNN Accelerator labels Oct 15, 2025
@CISC
Copy link
Collaborator

CISC commented Oct 15, 2025

@ggerganov Looks like we no longer have any maintainers for the SYCL backend, unless @NeoZhangJianyu reappears...

@yael-works
Copy link
Contributor Author

Hi @ggerganov

All CI checks are green (some still queued), and both @CISC and @qnixsynapse have reviewed the changes.
There are currently no active SYCL maintainers, so the PR can’t be approved automatically.

Could you please take a look and approve or merge when convenient?
This adds GGML_OP_MEAN support for the SYCL backend — tested and verified across platforms.

Thanks a lot for your time and great work maintaining the project!

Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good work!

Thank you!

@NeoZhangJianyu NeoZhangJianyu merged commit ee50ee1 into ggml-org:master Oct 16, 2025
125 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants