CPU: Add support for FLOOR,CEIL,ROUND and TRUNC unary operators #16083

safranowith · 2025-09-18T12:57:43Z

Add new unary operators: FLOOR, CEIL, ROUND and TRUNC.

This PR adds support for the GGML_UNARY_OP_FLOOR, GGML_UNARY_OP_CEIL, GGML_UNARY_OP_ROUND and GGML_UNARY_OP_TRUNC operators to the GGML library.

Summary of changes:
Extended the ggml_unary_op enum and updated related arrays and assertions.
Implemented the corresponding API functions and integrated them into the codebase.
Ensured full compatibility with the existing unary operator infrastructure.

Testing:
All existing automated tests pass successfully.

Motivation:
These additions expand the mathematical capabilities of GGML, allowing users to efficiently perform operations related to decimal point manipulation—such as rounding up, down, or truncating the fractional part—on tensors.

- Added the operators to unary op enum - Implemented API functions - Implemented forward and unary-op logic in CPU backend - Updated ggml_get_n_tasks - Updated operators names array and static_assert - Updated docs and enabled automatic tests

ngxson · 2025-09-18T14:38:15Z

ggml/src/ggml.c

+
+//ggml_trunc
+
+struct ggml_tensor * ggml_trunc(


IMO the naming trunc is quite vast and can be misinterpreted as truncating only N fractional decimals. Naming like torch.frac or python's modf() makes more sense.

Thank you for your feedback!
I have added documentation above the ggml_trunc and ggml_trunc_inplace functions in ggml.h to clarify their behavior (they truncate the fractional part towards zero, similar to std::trunc).
Please let me know if further clarification is needed.

ggerganov · 2025-09-22T18:46:00Z

Can merge after fixing the EditorConfig CI

CISC · 2025-10-07T11:28:51Z

This looks ready for merge after rebase, forgotten?

CISC · 2025-10-09T12:01:27Z

@safranowith gentle ping

CISC · 2025-10-15T09:13:04Z

@safranowith I don't think that merge went exactly as planned. :)

safranowith · 2025-10-15T09:45:26Z

.All merge conflict markers have been cleaned up and the files are now updated .Let me know if the PR is now ready to be merge ‫בתאריך יום ד׳, 15 באוק׳ 2025 ב-12:13 מאת ‪Sigbjørn Skjæret‬‏ <‪ ***@***.***‬‏>:‬

…

*CISC* left a comment (ggml-org/llama.cpp#16083) <#16083 (comment)> @safranowith <https://github.com/safranowith> I don't think that merge went exactly as planned. :) — Reply to this email directly, view it on GitHub <#16083 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BT72BRJUJ36HM6CBLDENRID3XYF3NAVCNFSM6AAAAACG3UARIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBVGM3TSOBTHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

docs/ops.md

ggml/include/ggml.h

ggml/src/ggml-cpu/ops.cpp

ggml/src/ggml-cpu/unary-ops.h

CISC · 2025-10-15T09:48:09Z

.All merge conflict markers have been cleaned up and the files are now updated .Let me know if the PR is now ready to be merge

A few more artifacts left to fix.

… artifacts

safranowith · 2025-10-15T10:22:13Z

.Thanks for the feedback! I've applied the suggested changes .Please let me know if everything looks good now and if this is ready to be merged ‫בתאריך יום ד׳, 15 באוק׳ 2025 ב-12:48 מאת ‪Sigbjørn Skjæret‬‏ <‪ ***@***.***‬‏>:‬

…

*CISC* left a comment (ggml-org/llama.cpp#16083) <#16083 (comment)> .All merge conflict markers have been cleaned up and the files are now updated .Let me know if the PR is now ready to be merge A few more artifacts left to fix. — Reply to this email directly, view it on GitHub <#16083 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BT72BRM6Z2PLYGN7RHOZLOL3XYJ67AVCNFSM6AAAAACG3UARIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBVGUZTKNZQGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

CISC · 2025-10-15T12:53:45Z

.Thanks for the feedback! I've applied the suggested changes .Please let me know if everything looks good now and if this is ready to be merged

All good now, thank you, will merge once CI is done.

giuseppe · 2025-10-15T13:20:37Z

ggml/include/ggml.h

        GGML_UNARY_OP_FLOOR,
        GGML_UNARY_OP_CEIL,
        GGML_UNARY_OP_ROUND,
        GGML_UNARY_OP_TRUNC,


looks like a rebase artifact

These lines are not a rebase artifact – they are newly introduced unary ops that don't exist in master.
Confirmed via git diff master -- ggml/include/ggml.h.

giuseppe · 2025-10-15T13:20:43Z

ggml/src/ggml-cpu/ops.cpp

    }
 }

 template<typename src_t, typename dst_t>


safranowith · 2025-10-15T13:46:59Z

Thanks again for the review and approvals! I noticed that some CI checks are failing. Just to confirm — are those failures related to my changes, or unrelated? ‫בתאריך יום ד׳, 15 באוק׳ 2025 ב-15:54 מאת ‪Sigbjørn Skjæret‬‏ <‪ ***@***.***‬‏>:‬

…

*CISC* left a comment (ggml-org/llama.cpp#16083) <#16083 (comment)> .Thanks for the feedback! I've applied the suggested changes .Please let me know if everything looks good now and if this is ready to be merged All good now, thank you, will merge once CI is done. — Reply to this email directly, view it on GitHub <#16083 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BT72BRLAPWZGNJFNGEDAKZL3XY7W7AVCNFSM6AAAAACG3UARIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBWGI4TCNRYGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

safranowith · 2025-10-15T14:12:43Z

Let me know if there's anything I should address. ‫בתאריך יום ד׳, 15 באוק׳ 2025 ב-16:46 מאת ש.שפרנוביץ ***@***.*** ‬‏>:‬

…

Thanks again for the review and approvals! I noticed that some CI checks are failing. Just to confirm — are those failures related to my changes, or unrelated? ‫בתאריך יום ד׳, 15 באוק׳ 2025 ב-15:54 מאת ‪Sigbjørn Skjæret‬‏ <‪ ***@***.***‬‏>:‬ > *CISC* left a comment (ggml-org/llama.cpp#16083) > <#16083 (comment)> > > .Thanks for the feedback! I've applied the suggested changes .Please let > me know if everything looks good now and if this is ready to be merged > > All good now, thank you, will merge once CI is done. > > — > Reply to this email directly, view it on GitHub > <#16083 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BT72BRLAPWZGNJFNGEDAKZL3XY7W7AVCNFSM6AAAAACG3UARIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBWGI4TCNRYGU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

CISC · 2025-10-15T19:21:32Z

Thanks again for the review and approvals! I noticed that some CI checks are failing. Just to confirm — are those failures related to my changes, or unrelated?

Unrelated.

safranowith · 2025-10-16T09:24:12Z

Thanks! Now that the CPU implementation is approved and merged, I’ll continue with supporting these operators in other backends (e.g. CUDA, SYCL). Let me know if you have any guidance or preferences regarding that direction. ‫בתאריך יום ד׳, 15 באוק׳ 2025 ב-22:25 מאת ‪Sigbjørn Skjæret‬‏ <‪ ***@***.***‬‏>:‬

…

Merged #16083 <#16083> into master. — Reply to this email directly, view it on GitHub <#16083 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BT72BRJQAQWS3K33LTNCDLD3X2NSBAVCNFSM6AAAAACG3UARIKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGMYDGOBQGY3TCMQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

github-actions bot added documentation Improvements or additions to documentation ggml changes relating to the ggml tensor library for machine learning labels Sep 18, 2025

ngxson reviewed Sep 18, 2025

View reviewed changes

docs: add documentation for ggml_trunc and ggml_trunc_inplace in ggml.h

20aa499

ggerganov approved these changes Sep 22, 2025

View reviewed changes

chore: remove trailing whitespace from ggml.h

95b3127

safranowith requested a review from slaren as a code owner September 25, 2025 10:54

ngxson approved these changes Sep 29, 2025

View reviewed changes

Merged updates from llama/master with conflict resolution

4866260

Remove unresolved merge markers

f340abc

CISC reviewed Oct 15, 2025

View reviewed changes

docs/ops.md Show resolved Hide resolved

ggml/include/ggml.h Show resolved Hide resolved

ggml/src/ggml-cpu/ops.cpp Outdated Show resolved Hide resolved

ggml/src/ggml-cpu/unary-ops.h Outdated Show resolved Hide resolved

Apply review suggestions: cleanup formatting, enum order and leftover…

2bd2a5a

… artifacts

Regenerate ops.md using create_ops_docs.py

bcb1c8d

giuseppe reviewed Oct 15, 2025

View reviewed changes

CISC merged commit 466c191 into ggml-org:master Oct 15, 2025
68 of 71 checks passed


		//ggml_trunc

		struct ggml_tensor * ggml_trunc(

CPU: Add support for FLOOR,CEIL,ROUND and TRUNC unary operators #16083

CPU: Add support for FLOOR,CEIL,ROUND and TRUNC unary operators #16083

Uh oh!

Conversation

safranowith commented Sep 18, 2025

Uh oh!

ngxson Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

safranowith Sep 21, 2025

Choose a reason for hiding this comment

Uh oh!

ggerganov commented Sep 22, 2025

Uh oh!

CISC commented Oct 7, 2025

Uh oh!

CISC commented Oct 9, 2025

Uh oh!

CISC commented Oct 15, 2025

Uh oh!

safranowith commented Oct 15, 2025 via email

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CISC commented Oct 15, 2025

Uh oh!

safranowith commented Oct 15, 2025 via email

Uh oh!

CISC commented Oct 15, 2025

Uh oh!

giuseppe Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

safranowith Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

giuseppe Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

safranowith commented Oct 15, 2025 via email

Uh oh!

safranowith commented Oct 15, 2025 via email

Uh oh!

CISC commented Oct 15, 2025

Uh oh!

Uh oh!

safranowith commented Oct 16, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants