-
Notifications
You must be signed in to change notification settings - Fork 13.4k
ggml-cpu: implement MXFP4 SIMD for s390x #16193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
618ef46
ggml-cpu: impl mxfp4 s390x
taronaeo 6549e3b
ggml-cpu: missing s = sumf
taronaeo 377d0fc
ggml-cpu: fix incorrect kval_mxfp4 type
taronaeo 3538930
ggml-cpu: rework mxfp4
taronaeo cf927d8
ggml-cpu: missing delta calc
taronaeo ae718c7
ggml-cpu: fix typo
taronaeo f7e7539
ggml-cpu: fix typo for vec_splats
taronaeo 5fb1bb9
ggml-cpu: expand to 2 blocks per loop
taronaeo 4f85c33
ggml-cpu: add unroll to boost perf
taronaeo 1fe5572
ggml-cpu: back to 1 block per loop to test perf
taronaeo 1f99e51
Revert "ggml-cpu: back to 1 block per loop to test perf"
taronaeo 96cba33
ggml-cpu: rm unroll from single block
taronaeo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unroll seems unnecessary, since this loop should only have zero or one iterations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed in latest commit