model-conversion : fix the make targets in the README.md #16209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

danbev merged 1 commit into ggml-org:master from DamonFool:model-conversion

Sep 24, 2025

Contributor

DamonFool commented Sep 24, 2025

Fix two incorrect make targets in the readme.


          model-conversion : fix the make targets in the README.md

19de1dd

Signed-off-by: Jie Fu <[email protected]>

DamonFool requested a review from ggerganov as a code owner

September 24, 2025 03:29

github-actions bot added the examples label

danbev approved these changes

View reviewed changes

danbev merged commit 8ba548d into ggml-org:master

1 check passed

Member

danbev commented Sep 24, 2025 •

edited

Loading

I was expecting to be added automatically as a reviewer for this PR as I'm listed for this directory in CODEOWNERS but I was not. I'll look into this but if anyone can spot an issue with the entry please let me know.

Update: So it looks like I am listed as a code owner, for example for the Makefile if you hover over the shield icon you can see:

Owned by you (from CODEOWNERS line 37)

But the README.md has:

Owned by ggerganov (from CODEOWNERS line 104)

And in CODEOWNERS

101 CMakeLists.txt                          @ggerganov

@ggerganov Should this perhaps be /CMakeLists.txt instead? Perhaps that will avoid this issue, though I'm not sure.

Member

ggerganov commented Sep 24, 2025

Should this perhaps be /CMakeLists.txt instead?

Yes, this should work. Could you open a PR and change all the files from the root folder to have a slash prefix?

danbev added a commit to danbev/llama.cpp that referenced this pull request


          codeowners : use slash prefix for root files [no ci]

544eadd

This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: ggml-org#16209 (comment)

danbev mentioned this pull request

codeowners : use slash prefix for root files [no ci] #16210

Merged

Contributor Author

DamonFool commented Sep 24, 2025

Thanks @danbev .

DamonFool deleted the model-conversion branch

September 24, 2025 06:09

danbev added a commit that referenced this pull request


          codeowners : use slash prefix for root files [no ci] (#16210)

4d9ea03

This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: #16209 (comment)

pwilkin pushed a commit to pwilkin/llama.cpp that referenced this pull request


          model-conversion : fix the make targets in the README.md (ggml-org#16209

258332a

)

Fix two incorrect make targets in the readme.

Signed-off-by: Jie Fu <[email protected]>

pwilkin pushed a commit to pwilkin/llama.cpp that referenced this pull request


          codeowners : use slash prefix for root files [no ci] (ggml-org#16210)

fb96541

This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: ggml-org#16209 (comment)

struct pushed a commit to struct/llama.cpp that referenced this pull request


          model-conversion : fix the make targets in the README.md (ggml-org#16209

e7e34fc

)

Fix two incorrect make targets in the readme.

Signed-off-by: Jie Fu <[email protected]>

struct pushed a commit to struct/llama.cpp that referenced this pull request


          codeowners : use slash prefix for root files [no ci] (ggml-org#16210)

367caa3

This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: ggml-org#16209 (comment)

yael-works pushed a commit to yael-works/llama.cpp that referenced this pull request


          model-conversion : fix the make targets in the README.md (ggml-org#16209

c21ee62

)

Fix two incorrect make targets in the readme.

Signed-off-by: Jie Fu <[email protected]>

yael-works pushed a commit to yael-works/llama.cpp that referenced this pull request


          codeowners : use slash prefix for root files [no ci] (ggml-org#16210)

ad77b8f

This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: ggml-org#16209 (comment)

pwilkin pushed a commit to pwilkin/llama.cpp that referenced this pull request


          model-conversion : fix the make targets in the README.md (ggml-org#16209

ae388e4

)

Fix two incorrect make targets in the readme.

Signed-off-by: Jie Fu <[email protected]>

pwilkin pushed a commit to pwilkin/llama.cpp that referenced this pull request


          codeowners : use slash prefix for root files [no ci] (ggml-org#16210)

fb170b1

This commit adds a leading slash to the paths of root-level files
in the CODEOWNERS file.

The motivation for this is that these might otherwise match files
in subdirectories that have other/additional owners will override them.

Refs: ggml-org#16209 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels