common: fix missing chrono header for common.cpp #16211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
3 tasks
ggerganov
approved these changes
Sep 24, 2025
|
Thank you for your quick review! 😄 |
pwilkin
pushed a commit
to pwilkin/llama.cpp
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Uilian Ries <[email protected]>
struct
pushed a commit
to struct/llama.cpp
that referenced
this pull request
Sep 26, 2025
Signed-off-by: Uilian Ries <[email protected]>
yael-works
pushed a commit
to yael-works/llama.cpp
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Uilian Ries <[email protected]>
pwilkin
pushed a commit
to pwilkin/llama.cpp
that referenced
this pull request
Oct 23, 2025
Signed-off-by: Uilian Ries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
The llama.cpp project is available through many package managers, including Conan. During the current version update there (PR conan-io/conan-center-index#28435), we found the Windows build failed with the following error:
Doing a quick read in
common.cpp, it misses the C++11 headerchrono. This PR is related to #11836The CI there is using Windows + MSVC 194 + Release + C++14, in case you want to try to reproduce that scenario. And Llama is built as a shared library in that case. Previously, we did not note this error when building with MSVC 193, it started with the new version of Visual Studio compiler.
Let me know if you need more information about that case. Regards!