Skip to content

Conversation

@Rohanjames1997
Copy link
Contributor

The i8mm kernels require nrc == 2 to actually get triggered.
But currently, the CI's test-quantize-fns.cpp tests only the scenario where nrc=1.

@github-actions github-actions bot added the testing Everything test related label Sep 24, 2025
@Rohanjames1997
Copy link
Contributor Author

Hi @ggerganov , could you trigger the CI again?
Thanks!

@Rohanjames1997
Copy link
Contributor Author

Rohanjames1997 commented Sep 29, 2025

@ggerganov thanks for running the CI!
The failing checks seem unrelated to this PR. Weirdly enough, the "Build on RISCV Linux Machine by Cloud-V" failed at the repo checkout step itself.

Let me know if I can make any more changes


float result = INFINITY;
qfns_cpu->vec_dot(test_size, &result, 0, tmp_q1.data(), 0, tmp_q2.data(), 0, 1);
qfns_cpu->vec_dot(test_size, &result, 0, tmp_q1.data(), 0, tmp_q2.data(), 0, nrc);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to expand the input data depending on nrc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Can you tell me an appropriate test_size for nrc=2 ? Would it just be double?

@Rohanjames1997
Copy link
Contributor Author

I went through the logs of some of the failed tests and it looks like they may be unrelated to the modified CI in this PR. @ggerganov or the team, can you help me with this/ tell me if I'm missing something?

Thank you!

@snadampal
Copy link
Contributor

@Rohanjames1997 , how about you rebase the PR to the main? that will trigger CI and you can check if the current failures have been fixed on the mainline already.

@Rohanjames1997
Copy link
Contributor Author

Some CI failed again due to the Cloudflare/Github outage yesterday.
Rebased it again 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants