Extend CI for i8mm kernels as well #16234
Open
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ggerganov , could you trigger the CI again? |
|
@ggerganov thanks for running the CI! Let me know if I can make any more changes |
ggerganov
reviewed
Sep 29, 2025
ggerganov
reviewed
Sep 29, 2025
|
|
||
| float result = INFINITY; | ||
| qfns_cpu->vec_dot(test_size, &result, 0, tmp_q1.data(), 0, tmp_q2.data(), 0, 1); | ||
| qfns_cpu->vec_dot(test_size, &result, 0, tmp_q1.data(), 0, tmp_q2.data(), 0, nrc); |
There was a problem hiding this comment.
I think we need to expand the input data depending on nrc?
There was a problem hiding this comment.
Sure. Can you tell me an appropriate test_size for nrc=2 ? Would it just be double?
|
I went through the logs of some of the failed tests and it looks like they may be unrelated to the modified CI in this PR. @ggerganov or the team, can you help me with this/ tell me if I'm missing something? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The i8mm kernels require
nrc == 2to actually get triggered.But currently, the CI's test-quantize-fns.cpp tests only the scenario where
nrc=1.