Skip to content

Update the docs on -t --threads #16236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2025
Merged

Update the docs on -t --threads #16236

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eba9734
Update the docs on -t --threads
takasurazeem Sep 24, 2025
511cff3
Revert "Update the docs on -t --threads"
takasurazeem Oct 9, 2025
d8077e9
docs: clarify -t/--threads parameter uses CPU threads and defaults to…
takasurazeem Oct 9, 2025
df30781
Update arg.cpp
takasurazeem Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/arg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1521,7 +1521,7 @@ common_params_context common_params_parser_init(common_params & params, llama_ex
).set_examples({LLAMA_EXAMPLE_MAIN, LLAMA_EXAMPLE_SPECULATIVE, LLAMA_EXAMPLE_LOOKUP}));
add_opt(common_arg(
{"-t", "--threads"}, "N",
string_format("number of threads to use during generation (default: %d)", params.cpuparams.n_threads),
string_format("number of CPU threads to use during generation (default: %d, use all available.)", params.cpuparams.n_threads),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is not to use all available, the logic is more complex than that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have taken out the "use all available" part, but kept the CPU because it makes it clearer. I will take a look at the logic and put up another PR with more descriptive message.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slaren I was thinking the same, saw it being set as 4 on an Ampere ARM machine with a bazillion cores in the past

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some logic to avoid using logical cores (e.g. from SMT), but it may not work well in the Ampere CPU.

[](common_params & params, int value) {
params.cpuparams.n_threads = value;
if (params.cpuparams.n_threads <= 0) {
Expand Down