Skip to content

ggml : make sure dst in ggml_set_rows gets a backend buffer #16319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CISC wants to merge 1 commit into from
Closed

ggml : make sure dst in ggml_set_rows gets a backend buffer #16319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ggml/src/ggml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3687,6 +3687,7 @@ struct ggml_tensor * ggml_set_rows(
result->op = GGML_OP_SET_ROWS;
result->src[0] = b;
result->src[1] = c;
result->src[2] = a; // make sure a gets a backend buffer
Copy link
Member

@ggerganov ggerganov Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason it ends up without a buffer is because you applied ggml_set_rows on a tensor that is not used by any other operation in the graph. And since the ggml_set_rows is also missing the dependency due to this bug, in the end nothing in the graph depends on this tensor and the allocator correctly decides to not allocate it.


return result;
}
Expand Down
Loading