Skip to content

Conversation

angt
Copy link
Collaborator

@angt angt commented Oct 1, 2025

This change moves cpp-httplib based URL parsing and client setup into a new header common/http.h, and integrates it in arg.cpp and run.cpp.

It is an iteration towards removing libcurl, while intentionally minimizing changes to existing code to guarantee the same behavior when LLAMA_CURL is used.

@angt angt requested a review from ggerganov as a code owner October 1, 2025 15:06
This change moves cpp-httplib based URL parsing and client setup into
a new header `common/http.h`, and integrates it in `arg.cpp` and `run.cpp`.

It is an iteration towards removing libcurl, while intentionally
minimizing changes to existing code to guarantee the same behavior when
`LLAMA_CURL` is used.

Signed-off-by: Adrien Gallouët <[email protected]>
@angt angt force-pushed the common-introduce-http.h-for-httplib-based-client branch from 87666f1 to 9f7ff88 Compare October 1, 2025 15:15
@ggerganov
Copy link
Member

I think this is the only relevant error that needs to be resolved before merge: https://github.com/ggml-org/llama.cpp/actions/runs/18166867333/job/51711390130?pr=16373#step:5:4676

@angt
Copy link
Collaborator Author

angt commented Oct 1, 2025

I only fixed run.cpp.
Here the list of files with the same "issue":

$ grep -rl "<windows.h>" . | xargs grep -L "WIN32_LEAN_AND_MEAN"
./tools/gguf-split/gguf-split.cpp
./tools/rpc/rpc-server.cpp
./ggml/src/ggml-cpu/kleidiai/kleidiai.cpp
./ggml/src/ggml-sycl/dpct/helper.hpp
./ggml/src/ggml-vulkan/ggml-vulkan.cpp
./ggml/src/ggml-vulkan/vulkan-shaders/vulkan-shaders-gen.cpp
./common/log.cpp

I think we should use a common header to cleanup everything.

@ggerganov ggerganov merged commit 4201dea into ggml-org:master Oct 1, 2025
63 of 68 checks passed
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Oct 2, 2025
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Oct 2, 2025
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Oct 2, 2025
yael-works pushed a commit to yael-works/llama.cpp that referenced this pull request Oct 15, 2025
* common: introduce http.h for httplib-based client

This change moves cpp-httplib based URL parsing and client setup into
a new header `common/http.h`, and integrates it in `arg.cpp` and `run.cpp`.

It is an iteration towards removing libcurl, while intentionally
minimizing changes to existing code to guarantee the same behavior when
`LLAMA_CURL` is used.

Signed-off-by: Adrien Gallouët <[email protected]>

* tools : add missing WIN32_LEAN_AND_MEAN

Signed-off-by: Adrien Gallouët <[email protected]>

---------

Signed-off-by: Adrien Gallouët <[email protected]>
Signed-off-by: Adrien Gallouët <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants