-
Notifications
You must be signed in to change notification settings - Fork 13.4k
ggml webgpu: profiling, CI updates, reworking of command submission #16452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+517
−249
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5ae936a
Add profiling
reeselevine bd3d080
More detailed profiling
reeselevine 400a58d
Rework command submission to avoid global locks
reeselevine ca43faa
Update wait handling
reeselevine 98d98a2
try new method of waiting on futures
reeselevine 26c44f8
Add serializing of command submission in some cases
reeselevine eabab9e
Add new pool for timestamp queries and clean up logging
reeselevine c30b22e
Serialize command submission in CI and leave a TODO note
reeselevine 168dd72
Merge remote-tracking branch 'upstream/master'
reeselevine b926b0c
Update webgpu CI
reeselevine d501ef4
Add myself as WebGPU codeowner
reeselevine d56e061
Deadlock avoidance
reeselevine bcf8d9b
Leave WebGPU/Vulkan CI serialized
reeselevine 8a848cb
Fix divide by 0
reeselevine d3c7ddd
Fix logic in division by inflight_threads
reeselevine a5e26c2
Update CODEOWNERS and remove serialize submit option
reeselevine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -444,8 +444,8 @@ jobs: | |
# This is using llvmpipe and runs slower than other backends | ||
ctest -L main --verbose --timeout 4200 | ||
|
||
ubuntu-22-cmake-webgpu: | ||
runs-on: ubuntu-22.04 | ||
ubuntu-24-cmake-webgpu: | ||
runs-on: ubuntu-24.04 | ||
|
||
steps: | ||
- name: Clone | ||
|
@@ -455,16 +455,34 @@ jobs: | |
- name: ccache | ||
uses: ggml-org/[email protected] | ||
with: | ||
key: ubuntu-22-cmake-webgpu | ||
key: ubuntu-24-cmake-webgpu | ||
evict-old-files: 1d | ||
|
||
- name: Vulkan SDK Dependencies | ||
id: vulkan-depends | ||
- name: Dependencies | ||
id: depends | ||
run: | | ||
wget -qO - https://packages.lunarg.com/lunarg-signing-key-pub.asc | sudo apt-key add - | ||
sudo wget -qO /etc/apt/sources.list.d/lunarg-vulkan-jammy.list https://packages.lunarg.com/vulkan/lunarg-vulkan-jammy.list | ||
sudo add-apt-repository -y ppa:kisak/kisak-mesa | ||
sudo apt-get update -y | ||
sudo apt-get install -y build-essential mesa-vulkan-drivers vulkan-sdk libcurl4-openssl-dev | ||
sudo apt-get install -y build-essential mesa-vulkan-drivers libxcb-xinput0 libxcb-xinerama0 libxcb-cursor-dev libcurl4-openssl-dev | ||
|
||
- name: Get latest Vulkan SDK version | ||
id: vulkan_sdk_version | ||
run: | | ||
echo "VULKAN_SDK_VERSION=$(curl https://vulkan.lunarg.com/sdk/latest/linux.txt)" >> "$GITHUB_ENV" | ||
|
||
- name: Use Vulkan SDK Cache | ||
uses: actions/cache@v4 | ||
id: cache-sdk | ||
with: | ||
path: ./vulkan_sdk | ||
key: vulkan-sdk-${{ env.VULKAN_SDK_VERSION }}-${{ runner.os }} | ||
|
||
- name: Setup Vulkan SDK | ||
if: steps.cache-sdk.outputs.cache-hit != 'true' | ||
uses: ./.github/actions/linux-setup-vulkan | ||
with: | ||
path: ./vulkan_sdk | ||
version: ${{ env.VULKAN_SDK_VERSION }} | ||
|
||
- name: Dawn Dependency | ||
id: dawn-depends | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.