Skip to content

server : fix division by zero when reporting stats #16501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

server : fix division by zero when reporting stats #16501

merged 1 commit into from
Oct 10, 2025

Conversation

ggerganov
Copy link
Member

The t_token_generaion could become zero, causing division by zero here:

llama.cpp/tools/server/server.cpp

Line 1838 in 66892e1

timings.predicted_per_second = 1e3 / t_token_generation * n_decoded;

@ggerganov ggerganov requested a review from ngxson as a code owner October 10, 2025 15:18
@ggerganov ggerganov merged commit e60f01d into master Oct 10, 2025
69 checks passed
@ggerganov ggerganov deleted the gg/server-fix-div-by-0 branch October 10, 2025 19:15
yael-works pushed a commit to yael-works/llama.cpp that referenced this pull request Oct 15, 2025
@ggerganov @yael-works
server : fix division by zero when reporting stats (ggml-org#16501)
45a280d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbev danbev danbev approved these changes

@ngxson ngxson Awaiting requested review from ngxson ngxson is a code owner

Assignees

No one assigned

Labels

examples server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggerganov @danbev