ggml-cpu: build fails with -Werror=discarded-qualifiers

[otegami]

Why it failed

When compiling with strict compiler flags (-Wwrite-strings -Werror=discarded-qualifiers), the build fails with the following error:

$ cmake \
    -S . \
    -B ../llama.cpp.build \
    --preset=x64-linux-gcc-debug \
    -DCMAKE_INSTALL_PREFIX=/tmp/local \
    -DCMAKE_C_FLAGS="-Wwrite-strings -Werror=discarded-qualifiers" && \
  cmake --build ../llama.cpp.build/
...
/home/otegami/work/cpp/llama.cpp/ggml/src/ggml-cpu/ggml-cpu.c: In function ‘ggml_cpu_init’:
/home/otegami/work/cpp/llama.cpp/ggml/src/ggml-cpu/ggml-cpu.c:3572:24: error: passing argument 1 of ‘putenv’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
 3572 |                 putenv("KMP_BLOCKTIME=200"); // 200ms
      |                        ^~~~~~~~~~~~~~~~~~~
In file included from /home/otegami/work/cpp/llama.cpp/ggml/src/./ggml-impl.h:10,
                 from /home/otegami/work/cpp/llama.cpp/ggml/src/ggml-cpu/ggml-cpu-impl.h:6,
                 from /home/otegami/work/cpp/llama.cpp/ggml/src/ggml-cpu/traits.h:3,
                 from /home/otegami/work/cpp/llama.cpp/ggml/src/ggml-cpu/ggml-cpu.c:6:
/usr/include/stdlib.h:786:26: note: expected ‘char *’ but argument is of type ‘const char *’
  786 | extern int putenv (char *__string) __THROW __nonnull ((1));
      |                    ~~~~~~^~~~~~~~
cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed.

The issue is that putenv() expects a non-const char * but receives a string literal (const char *).

How to fix

This PR replaces putenv("KMP_BLOCKTIME=200") with setenv("KMP_BLOCKTIME", "200", 0).

Benefits of setenv():

• Accepts const char * parameters (no qualifier warnings)
• Makes copies of the strings (safer memory handling)
• The third parameter (0) ensures we don't overwrite if already set

Make sure to read the contributing guidelines before submitting a PR

[otegami]

📝 We couldn't use setenv on Windows. So I decided to use _putenv_s instead.

D:/a/llama.cpp/llama.cpp/ggml/src/ggml-cpu/ggml-cpu.c:3572:17: error: implicit declaration of function 'setenv'; did you mean 'getenv'? [-Wimplicit-function-declaration]
 3572 |                 setenv("KMP_BLOCKTIME", "200", 0); // 200ms
      |                 ^~~~~~
      |                 getenv

ref: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/putenv-s-wputenv-s